Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds timeout to Helm commands. #2570

Merged
merged 3 commits into from Oct 30, 2019
Merged

Adds timeout to Helm commands. #2570

merged 3 commits into from Oct 30, 2019

Conversation

alexec
Copy link
Contributor

@alexec alexec commented Oct 25, 2019 •
edited

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Optional. My organization is added to the README.
  • I've signed the CLA and my build is green (troubleshooting builds).

golangcibot
golangcibot reviewed Oct 25, 2019
View reviewed changes
util/helm/cmd.go Outdated Show resolved Hide resolved
@alexec @golangcibot
Update util/helm/cmd.go
cab7cab 
Co-Authored-By: Bot from GolangCI <42910462+golangcibot@users.noreply.github.com>
@codecov
Copy link

codecov bot commented Oct 25, 2019 •
edited

Codecov Report

Merging #2570 into master will increase coverage by 0.06%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #2570      +/-   ##
=========================================
+ Coverage   37.93%     38%   +0.06%     
=========================================
  Files         114     114              
  Lines       15866   15867       +1     
=========================================
+ Hits         6019    6030      +11     
+ Misses       9066    9052      -14     
- Partials      781     785       +4
Impacted Files Coverage Δ
util/helm/client.go 31.19% <0%> (ø) ⬆️
util/helm/cmd.go 34.21% <100%> (+0.58%) ⬆️
util/helm/helm.go 65.75% <100%> (+0.47%) ⬆️
cmd/argocd/commands/login.go 0% <0%> (ø) ⬆️
controller/appcontroller.go 45.7% <0%> (+1.22%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 73590e1...25fb987. Read the comment docs.

@alexec alexec marked this pull request as ready for review October 28, 2019 17:51
@alexec alexec merged commit 6930ecc into argoproj:master Oct 30, 2019
@alexec alexec deleted the helm-timeout branch October 30, 2019 23:41
alexec added a commit that referenced this pull request Oct 30, 2019
@alexec
Adds timeout to Helm commands. (#2570)
30935e2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@golangcibot golangcibot golangcibot left review comments

@alexmt alexmt alexmt approved these changes

Assignees

@alexmt alexmt

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@alexec @alexmt @golangcibot